sw/stm32 - Cryptech HSM on STM-32 ARM processor

Age	Commit message (Collapse)	Author
2017-03-23	Check CRC32 of data received from host.ft-crc32	Fredrik Thulin

2017-03-23	Fix UART RX communication errors resulting in byte swapping.	Fredrik Thulin
	Sometimes, the Half-Transfer Complete and Transfer Complete events execute in the wrong order. This happens when both the TC and HT bits get set before HAL_DMA_IRQHandler() runs. Don't know what causes that, but this mitigates the problem with a separate read index for the uart_rx buffer.
2017-03-02	Try to be a bit more robust in the face of normal errors.	Paul Selkirk
	If hal_rpc_server_dispatch() returns an XDR decode error because the request packet was too short, don't call Error_Handler() and kill the dispatch thread, just drop the request. Add more ibuf_queue entries, but don't panic and kill the dispatch thread if we can't get one, just drop the incoming character (which will lead to an XDR decode error if/when we finally get an ibuf).
2017-02-23	Add --pin and --quiet options.	Paul Selkirk

2017-02-23	Speed up file upload enormously.	Paul Selkirk
	We need to start with a long serial timeout, in order to catch the reboot messages for a firmware upload (this has to be done through the bootloader). But once we start sending the file, cut the serial timeout to 1ms. (I've tested it down to 1us, but that may not work for everyone, and it doesn't improve performance in a statistically significant way.) This brings the time to upload a 4.5MB bitstream from 38:23 to 1:25.
2017-02-22	Refactor flash code.	Paul Selkirk

2017-02-21	Use libcli return codes where appropriate; show whether PINs are set.	Paul Selkirk

2017-02-21	Use bulk erase in the one place it makes sense.	Paul Selkirk

2017-02-20	Move dangerous auto_erase functionality to where it's actually used.	Paul Selkirk

2017-02-19	Remove unnecessary delays in flash code.	Paul Selkirk

2017-02-19	Simplify spiflash test code slightly, add keystore test code.	Paul Selkirk

2017-02-15	Add performance tests for spiflash_n25q128.c	Paul Selkirk

2017-02-15	Add n25q128_erase_bulk	Paul Selkirk

2017-02-02	Add locking around keystore operations.	Rob Austein

2016-12-23	Don't wrap key number in "keystore show keys".	Rob Austein

2016-12-21	Initialize PINs before trying to use them in bootloader.	Rob Austein

2016-12-21	Rewrite core upload loop to simplify and fix race conditions.	Rob Austein
	The main loop in cryptech_upload:send_file() was much more complicated than necessary, and also contained some hidden assumptions about serial I/O timing which happened to fail on the first two machines I tested. We already had a perfectly good buffered-input function, so rewrote to use that, and simplified control structure in the process. In theory, the new code should work in any environment where the old one did, but this has not yet been confirmed.
2016-12-20	Flush output to serial device after writing.	Rob Austein

2016-12-20	Merge branch 'master' into ksng	Rob Austein
	Bootloader DFU fixes.
2016-12-20	Make stm_flash_sector_num a little more efficient.	Paul Selkirk

2016-12-20	The bootloader upgrade reboots now, so we don't need to log out of the CLI.	Paul Selkirk

2016-12-20	Fix bootloader upload callback routine to write the correct number of bytes ↵	Paul Selkirk
	to flash. While we're at it, propagate error returns.
2016-12-20	cli_receive_data: re-enable UART DMA before returning. Based on Fredrik's ↵	Paul Selkirk
	fix to cli-test, commit ae8ebce.
2016-12-19	Merge branch 'master' into ksng.	Rob Austein
	Drag in UART-related changes from master.
2016-11-25	Add debugging code to cryptech_upload.	Rob Austein

2016-11-15	Reinitialize keystore data structures after wiping keystore flash.	Rob Austein

2016-11-14	Track removal of hal_rpc_pkey_list().	Rob Austein

2016-11-14	hal_rpc_pkey_find() -> hal_rpc_pkey_open().	Rob Austein

2016-11-02	Wait for WIP to clear before returning from erase operations too.	Rob Austein
	Wrong-block-type race condition errors went away after adding the WIP check after flash write operations, then came back once (isolated incident) while running a series of tests which had written enough flash blocks that ks_flash may have finally had to erase something rather than just zeroing. Code inspection confirmed that the erase code was not waiting for WIP to clear before exiting. Difficult to prove that this was the cause of an unreproducible failure, but seems like a likely candidate given previous behavior and change should be harmless, so adding it. Timeout for this flag check is 2000 ms, which is what other erase-related WIP flag checks were already using.
2016-11-01	Tweak CLI keystore commands for latest libhal RPC keystore API.	Rob Austein
	Using {-1} as a client handle in the CLI is a kludge, but the new stricter libhal keystore code really wants us to be consistent about this, so as long as any part of the CLI is using client {-1}, it all needs to do so. This still isn't really right, the CLI probably needs a different set of access rules than those which apply to the RPC calls, but I'm deferring that until we know what the "final" (for this branch) version of the RPC API looks like, and have done whatever refactoring might be required in the libhal keystore drivers.
2016-11-01	Don't return from flash write calls until WIP flag clears.	Rob Austein
	Absence of this check created a nasty race condition in sw/libhal/ks_flash.c, which didn't show up until we had test code which attempted to delete a long series of keys in quick succession. I'm not aware of any sane reason why we would ever want to skip this check, so it's unconditional and applies to all of the SPI flash code, not just the keystore flash code.
2016-10-09	Track changes to libhal pkey API.	Rob Austein

2016-10-07	Track changes to libhal RPC pkey API.	Rob Austein

2016-10-07	strcasecmp() is not a standard function.	Rob Austein

2016-09-27	"keystore erase" now clears entire keystore flash.	Rob Austein
	Now that we're using more than just the first few sectors of the keystore flash, we need a command to clear the whole thing. This is not quite right yet, because it doesn't yet notify libhal's ks_flash driver that the entire content of the flash has been yanked out from under it. In theory, we should be able to erase the entire flash in a single operation using the bulk erase command command (0xC7), but I couldn't get that to do anything (no error reported, no visible effect), so, for now, we erase by sectors.
2016-09-26	Fix function pointer type, typo in variable name.	Rob Austein

2016-09-23	Use subsectors instead of sectors in keystore.	Rob Austein

2016-09-20	Still some problem with uart receive under heavy load, so change to a 2-byte ↵	Paul Selkirk
	receive buffer with half-complete callbacks, and raise the dma priority.
2016-09-16	Change default gcc optimization level to -Og.	Rob Austein

2016-09-16	Revised ks_flash. Compiles, not yet tested.	Rob Austein

2016-09-13	Track libhal cleanup (function names, const-ification).	Rob Austein

2016-09-09	Fix frelling sw/stm32/Makefile to rebuild libraries properly.	Rob Austein

2016-09-09	Track removal of `type` argument from hal_rpc_pkey_find().	Rob Austein

2016-09-05	add bit-for-bit testing of FMC address and data bus	Fredrik Thulin

2016-09-02	Whack with club until working with new keystore API.	Rob Austein
	Basic stuff like "keystore show keys", "keystore delete key", and the PIN commands all work with the new keystore code. Some of the management commands are still broken. Some of the old management commands were using libhal-internal APIs for which no real equivalent exists anymore. Some of the old management commands were doing things that, um, never could have worked as written.
2016-09-01	"make clean" needs to use "rm -f" to avoid gratuitous failures.	Rob Austein

2016-08-23	Merge branch 'master' of git.cryptech.is:sw/stm32	Paul Selkirk

2016-08-23	Show running threads.	Paul Selkirk

2016-08-23	Reset table of cores after resetting FPGA from CLI.	Paul Selkirk

2016-08-23	Multi-client testing revealed race conditions in uart receive code	Paul Selkirk
	(dropped characters, improper handoff of message buffers). Fixed by a) changing the uart receiver from interrupt to DMA mode, and b) replacing the dispatch mutex and rpc semaphore with a mail queue (memory pool + message queue).