aboutsummaryrefslogtreecommitdiff
path: root/serial_internal.h
diff options
context:
space:
mode:
authorRob Austein <sra@hactrn.net>2017-04-23 18:30:50 -0400
committerRob Austein <sra@hactrn.net>2017-04-23 18:30:50 -0400
commitc9fc4a5779db08a6c8a0029b779826a188d8b438 (patch)
tree35a17eb13db940ce8cd67f38a683f325c150348b /serial_internal.h
parentf502844d18282c928cf5fedb483514c1fcfd0b92 (diff)
Avoid deadlock triggered by low-probability race condition.
Static code analysis (Doxygen call graph) detected a low-probability race condition which could have triggered a deadlock on the keystore mutex if the mkmif code returns with an error like HAL_ERROR_CORE_BUSY when we're trying to fetch the KEK. This is a knock-on effect of the awful kludge of backing up the KEK in the keystore flash as an alternative to powering the MKM with a battery as called for in the design. This code path should not exist at all, but, for now, we avoid the deadlock by making it the caller's responsibility to grab the keystore mutex before looking up the KEK.
Diffstat (limited to 'serial_internal.h')
0 files changed, 0 insertions, 0 deletions