diff options
| author | Rob Austein <sra@hactrn.net> | 2015-08-26 08:40:11 -0400 |
|---|---|---|
| committer | Rob Austein <sra@hactrn.net> | 2015-08-26 08:40:11 -0400 |
| commit | 1f8a59754c75af9b87e98c19dfc81fa4cc069555 (patch) | |
| tree | 513d38c2544967c3edd456342ae6d001d3bfdae2 | |
| parent | 821f7d6bf05601811cf9b4e9a5513374e3261d0b (diff) | |
Signature works better if we read the entire hash.
| -rw-r--r-- | ecdsa.c | 6 | ||||
| -rw-r--r-- | tests/test-ecdsa.c | 2 |
2 files changed, 4 insertions, 4 deletions
@@ -79,7 +79,7 @@ */ #ifndef HAL_ECDSA_DEBUG_ONLY_STATIC_TEST_VECTOR_RANDOM -#define HAL_ECDSA_DEBUG_ONLY_STATIC_TEST_VECTOR_RANDOM 1 +#define HAL_ECDSA_DEBUG_ONLY_STATIC_TEST_VECTOR_RANDOM 0 #endif /* @@ -1122,7 +1122,7 @@ hal_error_t hal_ecdsa_sign(const hal_ecdsa_key_t * const key, hal_error_t err; - fp_read_unsigned_bin(e, unconst_uint8_t(hash), sizeof(hash_len)); + fp_read_unsigned_bin(e, unconst_uint8_t(hash), hash_len); do { @@ -1246,7 +1246,7 @@ hal_error_t hal_ecdsa_verify(const hal_ecdsa_key_t * const key, fp_cmp_d(s, 1) == FP_LT || fp_cmp(s, n) != FP_LT) return HAL_ERROR_INVALID_SIGNATURE; - fp_read_unsigned_bin(e, unconst_uint8_t(hash), sizeof(hash_len)); + fp_read_unsigned_bin(e, unconst_uint8_t(hash), hash_len); if (fp_invmod(s, n, w) != FP_OKAY || fp_mulmod(e, w, n, u1) != FP_OKAY || diff --git a/tests/test-ecdsa.c b/tests/test-ecdsa.c index 2cf2277..c4cf25f 100644 --- a/tests/test-ecdsa.c +++ b/tests/test-ecdsa.c @@ -115,7 +115,7 @@ static int test_against_static_vectors(const ecdsa_tc_t * const tc) { hal_error_t err; - printf("Starting static test vector tests for P-%d\n", tc->d_len * 8); + printf("Starting static test vector tests for P-%lu\n", (unsigned long) (tc->d_len * 8)); set_next_random(tc->d, tc->d_len); |